Skip to content

Bug fix - Sort the images paths for animations#1

Open
SavvasMel wants to merge 1 commit intoMeteoSwiss:ktezcan/dev/baseline_expsfrom
SavvasMel:SavvasMel/dev/baseline_exps/baseline_exps_eval_fix
Open

Bug fix - Sort the images paths for animations#1
SavvasMel wants to merge 1 commit intoMeteoSwiss:ktezcan/dev/baseline_expsfrom
SavvasMel:SavvasMel/dev/baseline_exps/baseline_exps_eval_fix

Conversation

@SavvasMel
Copy link

Description

The animations are related to reading paths of images and merge everything in a gif. However, sorting of the image paths was not taking place. This PR fixed that issue.

Issue Number

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant